Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak the readme to be more user facing #138

Merged
merged 5 commits into from
Oct 19, 2023
Merged

Tweak the readme to be more user facing #138

merged 5 commits into from
Oct 19, 2023

Conversation

hadley
Copy link
Member

@hadley hadley commented Oct 18, 2023 •
edited
Loading

Should I also setup keyring.r-lib.org?

@hadley hadley requested a review from gaborcsardi October 18, 2023 17:02
gaborcsardi
gaborcsardi reviewed Oct 18, 2023
View reviewed changes
Copy link
Member

@gaborcsardi gaborcsardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks nice! Just has some tiny comments.

README.Rmd Outdated Show resolved Hide resolved
README.Rmd Outdated Show resolved Hide resolved
README.Rmd Outdated Show resolved Hide resolved
@gaborcsardi
Copy link
Member

gaborcsardi commented Oct 19, 2023 •
edited
Loading

Should I also setup keyring.r-lib.org?

❯ dig keyring.r-lib.org | grep CNAME
keyring.r-lib.org.	300	IN	CNAME	r-lib.github.io.

It is set up, I'll change the config in a sec.

EDIT: done.

@gaborcsardi gaborcsardi merged commit e8d88e2 into main Oct 19, 2023
@gaborcsardi gaborcsardi deleted the readme branch October 19, 2023 18:03
@gaborcsardi
Copy link
Member

Thank you!

gaborcsardi pushed a commit that referenced this pull request Oct 20, 2023
@hadley @gaborcsardi
Tweak the readme to be more user facing (#138)
bd8a458
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborcsardi gaborcsardi gaborcsardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hadley @gaborcsardi