Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.1.* issue with handling of deprecated lint* arguments #2722

Open
MichaelChirico opened this issue Feb 11, 2025 · 0 comments
Open

4.1.* issue with handling of deprecated lint* arguments #2722

MichaelChirico opened this issue Feb 11, 2025 · 0 comments
Labels
internals Issues related to inner workings of lintr, i.e., not user-visible
Milestone

Comments

@MichaelChirico
Copy link
Collaborator

I'm seeing this on GHA:

== Failed tests ================================================================
-- Error ('test-lint_dir.R:92:3'): lint_dir works with specific linters without specifying other arguments --
Error in `check_dots(dot_names, c("lint", "exclude", "parse_exclusions"))`: x Found unknown arguments in `...`: `NA`.
i Check for typos and see ?eval for valid arguments.
Backtrace:
    x
 1. +-testthat::expect_length(...) at test-lint_dir.R:92:3
 2. | \-testthat::quasi_label(enquo(object), arg = "object")
 3. |   \-rlang::eval_bare(expr, quo_get_env(quo))
 4. \-lintr::lint_dir(the_dir, assignment_linter(), parse_settings = FALSE)
 5.   \-lintr:::check_dots(dot_names, c("lint", "exclude", "parse_exclusions")) at lintr/R/lint.R:152:3
 6.     \-cli::cli_abort(...) at lintr/R/utils.R:279:3
 7.       \-rlang::abort(...)
-- Error ('test-lint_dir.R:101:3'): linting empty directory passes -------------
Error in `check_dots(dot_names, c("lint", "exclude", "parse_exclusions"))`: x Found unknown arguments in `...`: `NA`.
i Check for typos and see ?eval for valid arguments.
Backtrace:
    x
 1. +-testthat::expect_length(...) at test-lint_dir.R:101:3
 2. | \-testthat::quasi_label(enquo(object), arg = "object")
 3. |   \-rlang::eval_bare(expr, quo_get_env(quo))
 4. \-lintr::lint_dir(withr::local_tempdir(), any_duplicated_linter())
 5.   \-lintr:::check_dots(dot_names, c("lint", "exclude", "parse_exclusions")) at lintr/R/lint.R:152:3
 6.     \-cli::cli_abort(...) at lintr/R/utils.R:279:3
 7.       \-rlang::abort(...)

e.g.

https://github.com/r-lib/lintr/actions/runs/13272849355/job/37056120641

I see some code already related to 4.1.{1,2}, not sure why it's still an issue on all of 4.1.*.

Filing for now without a plan to fix before release. If there's an easy fix, we can put it into a follow-up patch release (3.2.2). Otherwise, those arguments are slated for complete removal come next "real" release, so I would just ignore this & remove that code already.

@MichaelChirico MichaelChirico added this to the 3.3.0 milestone Feb 12, 2025
@MichaelChirico MichaelChirico added the internals Issues related to inner workings of lintr, i.e., not user-visible label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Issues related to inner workings of lintr, i.e., not user-visible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant