diff --git a/TODO.md b/TODO.md index e8036afbd..db7cc30f8 100644 --- a/TODO.md +++ b/TODO.md @@ -2,9 +2,6 @@ ## Next steps -- Benchmark and profile again - - `bench.R` - - https://github.com/tidyverse/tibble/issues/598 - Look for FIXMEs - Test coverage per file - Use penguins @@ -21,6 +18,10 @@ - Simplify matrix formatting to format like an array: https://github.com/r-lib/pillar/issues/142#issuecomment-489357664 - `tibble::tibble(a = structure(1000:1003, class = "foo"))` should right-align, because the underlying data is a number? - Blog post? +- Format and truncate in {utf8} +- Benchmark and profile again + - `bench.R` + - https://github.com/tidyverse/tibble/issues/598 ## Formatting numbers diff --git a/bench.R b/bench.R index aba97c061..06f7ff32b 100644 --- a/bench.R +++ b/bench.R @@ -10,8 +10,8 @@ df_all <- pillar:::new_tbl(list( i = list(list(1, 2:3), list(4:6), list(NA)) )) -# proffer::pprof(filter.callframes = TRUE, -# for (i in 1:100) format(df_all) -# ) +proffer::pprof(filter.callframes = TRUE, + for (i in 1:200) format(df_all) +) -bench::mark(format(df_all), iterations = 500) +# bench::mark(format(df_all), iterations = 500)