Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendering citHeader() in inst/CITATION #2835

Open
Rafnuss opened this issue Jan 16, 2025 · 1 comment
Open

Rendering citHeader() in inst/CITATION #2835

Rafnuss opened this issue Jan 16, 2025 · 1 comment
Labels
front end 🌷 General HTML, CSS, and JS issues

Comments

@Rafnuss
Copy link
Contributor

Rafnuss commented Jan 16, 2025

If I'm not mistaken, citHeader() are not render in build_home() if presen in the CITATION.
Is this intentional? If so why? and if not, how difficult would it be to implement? I had a quick look but couldn't make a suggestion, sorry.
Thanks a lot for this cool package!
@jayhesselberth
Copy link
Collaborator

We just use utils::readCitationFile() to read data from CITATION.

pkgdown/R/build-home-authors.R

Line 236 in 6615322

utils::readCitationFile(cit_path, meta = meta)

But we don't explicitly drop the header / footer. So either CITATION is not read correctly, or we're not using those components in the templating. I think R was moving away fromcitation() and friends and recommending bibEntry() instead, could be related.

A PR would be welcome if you'd like to take a look.

@jayhesselberth jayhesselberth added the front end 🌷 General HTML, CSS, and JS issues label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
front end 🌷 General HTML, CSS, and JS issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jayhesselberth @Rafnuss