You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The message returned by [p]tags list isn't sanitised to escape markdown syntax. This results in broken output with anything as simple as _ in tag names.
To Reproduce
Steps to reproduce the behavior:
Add a tag with a name including markdown control characters, e.g. my_test_tag_
Run [p]tags list
See broken output
Expected behavior
Markdown should be escaped. This is trivial with redbot.core.utils.chat_formatting.escape.
As a stretch, it would be nice if the output were paginated. This is also trivial with redbot.core.utils.chat_formatting.pagify or redbot.core.utils.menus. An example of the former can be found in penis.py, and the latter in notes.py.
Pagination would be nice as lots of tags results in a very long output, which could also run into message length limits. Worth noting that I haven't checked the code to see if this is correctly handled, but given the lack of pagination I'd guess it isn't or could at least be improved.
Screenshots
See italicised text near the end:
Additional context
The text was updated successfully, but these errors were encountered:
Describe the bug
The message returned by
[p]tags list
isn't sanitised to escape markdown syntax. This results in broken output with anything as simple as_
in tag names.To Reproduce
Steps to reproduce the behavior:
my_test_tag_
[p]tags list
Expected behavior
Markdown should be escaped. This is trivial with
redbot.core.utils.chat_formatting.escape
.As a stretch, it would be nice if the output were paginated. This is also trivial with
redbot.core.utils.chat_formatting.pagify
orredbot.core.utils.menus
. An example of the former can be found in penis.py, and the latter in notes.py.Pagination would be nice as lots of tags results in a very long output, which could also run into message length limits. Worth noting that I haven't checked the code to see if this is correctly handled, but given the lack of pagination I'd guess it isn't or could at least be improved.
Screenshots
See italicised text near the end:
Additional context
The text was updated successfully, but these errors were encountered: