From 9589fdf5bd71323d8b868f11aa83fe171977d7dd Mon Sep 17 00:00:00 2001 From: mmackz Date: Thu, 15 Aug 2024 13:13:27 -0700 Subject: [PATCH 1/3] test(titles): Update mint parameters and remove redundant test --- packages/titles/src/Titles.test.ts | 30 +++--------------------------- 1 file changed, 3 insertions(+), 27 deletions(-) diff --git a/packages/titles/src/Titles.test.ts b/packages/titles/src/Titles.test.ts index e181275d4..4cd66b6a4 100644 --- a/packages/titles/src/Titles.test.ts +++ b/packages/titles/src/Titles.test.ts @@ -137,11 +137,11 @@ describe('Given the getFee function', () => { describe('simulateMint function', () => { test('should simulate a V2 mint', async () => { const contractAddress: Address = - '0x432f4Ccc39AB8DD8015F590a56244bECb8D16933' + '0xc1eee0e85cf2356357ccad2cd1a60a5935538e4d' const mintParams = { contractAddress, - chainId: Chains.BASE, - tokenId: 4, + chainId: Chains.ZORA, + tokenId: 1, recipient: '0xf70da97812CB96acDF810712Aa562db8dfA3dbEF', } const value = parseEther('0.0005') @@ -158,30 +158,6 @@ describe('simulateMint function', () => { expect(request.functionName).toBe('mint') expect(request.value).toBe(value) }) - - test('should simulate a V2 mint', async () => { - const contractAddress: Address = - '0x06d7D870a41a44B5b7eBF46019bD5f8487362de3' - const mintParams = { - contractAddress, - chainId: Chains.BASE, - tokenId: 5, - recipient: '0xf70da97812CB96acDF810712Aa562db8dfA3dbEF', - } - const value = parseEther('0.0005') - const address = mintParams.recipient as Address - - const result = await simulateMint( - mintParams as MintIntentParams, - value, - address, - ) - - const request = result.request - expect(request.address).toBe('0x06d7D870a41a44B5b7eBF46019bD5f8487362de3') - expect(request.functionName).toBe('mint') - expect(request.value).toBe(value) - }) }) describe('getExternalUrl function', () => { From 931c9c035e1a32cd2c7f4ab7866556d222099afa Mon Sep 17 00:00:00 2001 From: mmackz Date: Thu, 15 Aug 2024 13:14:05 -0700 Subject: [PATCH 2/3] chore: generate changeset --- .changeset/moody-moose-shop.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/moody-moose-shop.md diff --git a/.changeset/moody-moose-shop.md b/.changeset/moody-moose-shop.md new file mode 100644 index 000000000..f45914f5f --- /dev/null +++ b/.changeset/moody-moose-shop.md @@ -0,0 +1,5 @@ +--- +"@rabbitholegg/questdk-plugin-titles": patch +--- + +fix failing tests for titles simulateMint From b3e0ca4ee36b7157397699582ec782e951f6eba0 Mon Sep 17 00:00:00 2001 From: mmackz Date: Thu, 15 Aug 2024 13:59:28 -0700 Subject: [PATCH 3/3] test(Titles): update expected address in mint test case --- packages/titles/src/Titles.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/titles/src/Titles.test.ts b/packages/titles/src/Titles.test.ts index 4cd66b6a4..8a1edefc7 100644 --- a/packages/titles/src/Titles.test.ts +++ b/packages/titles/src/Titles.test.ts @@ -154,7 +154,7 @@ describe('simulateMint function', () => { ) const request = result.request - expect(request.address).toBe('0x432f4Ccc39AB8DD8015F590a56244bECb8D16933') + expect(request.address).toBe('0xc1eee0e85cf2356357ccad2cd1a60a5935538e4d') expect(request.functionName).toBe('mint') expect(request.value).toBe(value) })