From e66240873db9a5d3efe1cbe743cebfda7e0b9fcf Mon Sep 17 00:00:00 2001 From: Samuel Williams Date: Wed, 12 Jun 2024 00:43:11 +0900 Subject: [PATCH] Don't add `content-length` header. --- lib/rack/test.rb | 1 - spec/fixtures/fake_app.rb | 3 --- spec/rack/test_spec.rb | 5 +++++ 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/rack/test.rb b/lib/rack/test.rb index 0b519e9..cba4066 100644 --- a/lib/rack/test.rb +++ b/lib/rack/test.rb @@ -363,7 +363,6 @@ def process_request(uri, env) close_body(body) cookie_jar.merge(last_response.headers['set-cookie'], uri) @after_request.each(&:call) - @last_response.finish yield @last_response if block_given? diff --git a/spec/fixtures/fake_app.rb b/spec/fixtures/fake_app.rb index 3cfeff2..1c9cb0b 100644 --- a/spec/fixtures/fake_app.rb +++ b/spec/fixtures/fake_app.rb @@ -6,9 +6,6 @@ module Test class FakeApp def call(env) _, h, b = res = handle(env) - length = 0 - b.each{|s| length += s.bytesize} - h['content-length'] = length.to_s h['content-type'] = 'text/html;charset=utf-8' res end diff --git a/spec/rack/test_spec.rb b/spec/rack/test_spec.rb index d71457a..7e01901 100644 --- a/spec/rack/test_spec.rb +++ b/spec/rack/test_spec.rb @@ -503,6 +503,11 @@ def closed? last_response['content-type'].must_equal 'text/html;charset=utf-8' end + it 'should not add a content-length header' do + request '/' + last_response['content-length'].must_be_nil + end + it 'raises an error if no requests have been issued' do proc do last_response