Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proportion vs. Percent #2

Open
jacobbien opened this issue Jul 27, 2022 · 3 comments
Open

Proportion vs. Percent #2

jacobbien opened this issue Jul 27, 2022 · 3 comments

Comments

@jacobbien
Copy link

Hi @vnijs !

In summary.full_factor() under "Fit Measures", it looks to me like the rows labeled "Variance %" and "Cumulative %" should be "Variance Prop" and "Cumulative Prop."

set_rownames(c("Eigenvalues", "Variance %", "Cumulative %")) %>%

Thanks!

@vnijs
Copy link
Contributor

vnijs commented Jul 28, 2022

Not sure I follow @jacobbien. Are you suggesting the current labels are incorrect?

@jacobbien
Copy link
Author

Yeah. The computed quantities in those two rows of the table appear to be proportions rather than percentages. So for example, when all of the variance is explained, it would say that the variance % is 1 rather than 100.

@vnijs
Copy link
Contributor

vnijs commented Jul 29, 2022

Ah. I see what you mean now. Thanks for the suggestion @jacobbien. Will get this fixed. Same thing in pre-factor and perceptual maps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants