Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify intensity units #56

Open
k-wolfinger opened this issue Jun 6, 2023 · 2 comments
Open

Clarify intensity units #56

k-wolfinger opened this issue Jun 6, 2023 · 2 comments
Assignees
Labels
1 1st priority

Comments

@k-wolfinger
Copy link
Member

No description provided.

@k-wolfinger k-wolfinger self-assigned this Jun 6, 2023
@bruhwiler
Copy link
Member

I'm not sure how important this is, but we want to specify with SRW every time to use 'arbitrary' units.

As long as we are consistent with how fields are initialized, we should get results with units that we understand.

I'm not sure what units we decided not to use for intensity -- presumably Watts, Watts/m^2 etc.

@bruhwiler
Copy link
Member

Lines 854 and 855 in pulse.py have some magic numbers for getting the intensity correct:
constant_factor = 1.198945869831954 # 7.3948753166511745
length_factor = constant_factor / (self.sig_s / params.nslice) # / self.ds

This code should be reviewed.

@bruhwiler bruhwiler added the 1 1st priority label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 1st priority
Projects
None yet
Development

No branches or pull requests

2 participants