Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More input sanitization #53

Open
nathanhillyer opened this issue Jul 28, 2020 · 4 comments
Open

More input sanitization #53

nathanhillyer opened this issue Jul 28, 2020 · 4 comments
Labels
enhancement New feature or request internal Tasks meant for internal development by project maintainers.

Comments

@nathanhillyer
Copy link
Contributor

Check data types, numpy array size, dimensionality, check for edge cases. Check to make sure input type is actually a numpy array. Invalid sizes. Make sure parameters are expected type, floats, negative numbers, etc.
@nathanhillyer nathanhillyer added the enhancement New feature or request label Jul 28, 2020
@robtoth robtoth added the internal Tasks meant for internal development by project maintainers. label Jul 30, 2020
@nathanhillyer
Copy link
Contributor Author

nathanhillyer commented Jul 30, 2020 •
edited
Loading

Throw an error if the image doesn't have any values greater than 1 and it's an integer array. Probably means the user mixed up the mask and the image.

@nathanhillyer
Copy link
Contributor Author

image

@nathanhillyer
Copy link
Contributor Author

When using 3D, make sure that an adequate number of slices are passed in the mask to calculate.

@nathanhillyer
Copy link
Contributor Author

nathanhillyer commented Sep 10, 2020 •
edited
Loading

Reference: https://github.com/Toth-Technology/bric-morphology

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request internal Tasks meant for internal development by project maintainers.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nathanhillyer @robtoth