Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a good reason that bounds does not return an Extent? #757

Closed
alex-s-gardner opened this issue Sep 20, 2024 · 5 comments
Closed

Comments

@alex-s-gardner
Copy link
Contributor

alex-s-gardner commented Sep 20, 2024

It seems like we should be converging on the use of Extents to describe bounds... for that reason I wonder why bounds doesn't return an Extent.

Along those lines I wonder why Rasters.bounds is not Rasters.extent

Just trying to think long-term here.

@alex-s-gardner alex-s-gardner changed the title Is there a good reason that bounds do not return an Extent? Is there a good reason that bounds does not return an Extent? Sep 20, 2024
@rafaqz
Copy link
Owner

rafaqz commented Sep 21, 2024

extent returns an extent! But maybe it should be exported.

Bounds are from before Extents existed.

@alex-s-gardner
Copy link
Contributor Author

if we're moving in the direction of #755, it would be good to start exporting Extents... though I also wonder if the right approach is GI.RectangleTrait so that you can pass a GI rectangular geometry to functions like crop, rasterize, GO.polygonize, GO.clip.

Maybe bounds remains untouched and a new function extents is introduced that exports an Extent or a GI.RectangleTrait

@rafaqz
Copy link
Owner

rafaqz commented Sep 21, 2024

Extents.extent is the function, we just need to export it

@alex-s-gardner
Copy link
Contributor Author

closed with #758

@alex-s-gardner
Copy link
Contributor Author

closed with #758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants