Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the create docs #880

Merged
merged 2 commits into from
Jan 31, 2025
Merged

fix the create docs #880

merged 2 commits into from
Jan 31, 2025

Conversation

tiemvanderdeure
Copy link
Collaborator

@tiemvanderdeure tiemvanderdeure commented Jan 30, 2025

such elaborate docs! Would be a shame if no one could read them

@tiemvanderdeure
Copy link
Collaborator Author

Doubt the test failures have much to do with this PR ;)

More likely it's because of rafaqz/DimensionalData.jl#915

@rafaqz
Copy link
Owner

rafaqz commented Jan 30, 2025

Yes, certainly is 😭

src/create.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.96%. Comparing base (a15ebb1) to head (20fe111).
Report is 156 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #880      +/-   ##
==========================================
+ Coverage   82.32%   82.96%   +0.63%     
==========================================
  Files          60       58       -2     
  Lines        4357     5317     +960     
==========================================
+ Hits         3587     4411     +824     
- Misses        770      906     +136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafaqz rafaqz merged commit d11aec7 into rafaqz:main Jan 31, 2025
4 checks passed
@tiemvanderdeure tiemvanderdeure deleted the create_docs branch February 6, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants