Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verbosity level for settings #10

Closed
kaat0 opened this issue May 4, 2022 · 6 comments
Closed

verbosity level for settings #10

kaat0 opened this issue May 4, 2022 · 6 comments
Assignees

Comments

@kaat0
Copy link
Collaborator

kaat0 commented May 4, 2022

No description provided.

@apriljunge
Copy link
Contributor

apriljunge commented May 13, 2024

I would suggest to use the packe of the julia standardlib julia logging (More info) and not introducing another setting option.
Using it would respect multiple possibilities to define the loglevel, filtering and if you want to log to a file, ...

@kaat0 kaat0 closed this as completed May 22, 2024
@kaat0 kaat0 reopened this May 22, 2024
@kaat0
Copy link
Collaborator Author

kaat0 commented May 22, 2024

  • convert println() into @debug, @info, @warn, @error messages

@kaat0
Copy link
Collaborator Author

kaat0 commented May 24, 2024

I have mainly implemented the verbosity setting so that Julia logging is used. In the past, Max and I have simply ignored it. I assume that when other people with little Julia experience come along, they will feel the same way. It helps if there are accesses to logging mechanisms that also exist in other programming worlds. For example, in the CLI world with Bash & co.

It also helps if the input and output of programs are reproducible. The trait of reproducibility includes that there is only one file with environment variables, currently Settings().

The other possibility would be storing the settings in a Julia-style environment.

@kaat0
Copy link
Collaborator Author

kaat0 commented May 26, 2024

See comment by @apriljunge e72c55f#commitcomment-142392830

@kaat0
Copy link
Collaborator Author

kaat0 commented May 28, 2024

I thought about introducing a extended logging based on common levels:

fatal: 3000,
error: 2000,
warn: 1000,
info: 0
debug: -1000
trace: -2000

I am not the only one with the impulse and "need".

After watching Logging in Julia@ JuliaCon 2023, I guess we have to be flexible for future changes in the Julia Logging Framework.

@kaat0
Copy link
Collaborator Author

kaat0 commented Jun 2, 2024

see LoggingExtras.jl/issues/91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants