-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Android import first wallet navigation stack #6393
Conversation
@@ -74,7 +74,7 @@ export default function useImportingWallet({ showImportModal = true } = {}) { | |||
const handleSetSeedPhrase = useCallback( | |||
(text: string) => { | |||
if (isImporting) return null; | |||
return setSeedPhrase(text); | |||
return setSeedPhrase(text.trim()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this removes any extraneous newlines when pasting. Got tired of seeing that.
Could be wrong but I think the most recent rebase removed 2 imports that file still wants |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will approve after lint fix 🫡
Fixes APP-2259
What changed (plus any additional context for devs)
1. Seed Phrase Handling
2. Wallet Loading State Management
3. Navigation Flow Improvements
Navigation.handleAction
:4. Code Cleanup
isValidBluetoothDeviceId
WalletBackupStepTypes
IS_TEST
This PR focuses on improving the wallet import experience by handling edge cases better, providing clearer loading states, and simplifying the navigation flow after import completion.
Screen recordings / screenshots
https://rainbowhaus.slack.com/archives/C0468CDBE75/p1736530454941719
What to test
importing, watching, restoring from backup, etc. etc.