We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There is a problem with the initial load for this project.
It will flicker on a fresh un-cached load:
This is more obvious if you intentionally slow down your network data to 3G using Chrome Dev tools etc.
The issue is a result of main.js being too slow to load and set the loading state.
main.js
On my fork at https://github.com/mobeigi/photography
I've fixed this and also made a handful of other improvements including:
I'd be happy to put up a PR for all of this, but my last pr was not reviewed so I don't know if its worth the time.
If it will be reviewed let me know and I can put up a PR @rampatra
The text was updated successfully, but these errors were encountered:
All the points you mentioned sounds interesting, would be great if you can raise a PR 🙏. And, your earlier PR is merged too.
Sorry, something went wrong.
Good to hear, I'll make a PR shortly with the improvements!
Successfully merging a pull request may close this issue.
There is a problem with the initial load for this project.
It will flicker on a fresh un-cached load:
chrome_5kVrmdbvHv.mp4
This is more obvious if you intentionally slow down your network data to 3G using Chrome Dev tools etc.
The issue is a result of
main.js
being too slow to load and set the loading state.On my fork at https://github.com/mobeigi/photography
I've fixed this and also made a handful of other improvements including:
I'd be happy to put up a PR for all of this, but my last pr was not reviewed so I don't know if its worth the time.
If it will be reviewed let me know and I can put up a PR @rampatra
The text was updated successfully, but these errors were encountered: