Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial loading flicker on first visit #114

Open
mobeigi opened this issue Aug 18, 2024 · 2 comments · May be fixed by #115
Open

Initial loading flicker on first visit #114

mobeigi opened this issue Aug 18, 2024 · 2 comments · May be fixed by #115

Comments

@mobeigi
Copy link
Contributor

mobeigi commented Aug 18, 2024

There is a problem with the initial load for this project.

It will flicker on a fresh un-cached load:

chrome_5kVrmdbvHv.mp4

This is more obvious if you intentionally slow down your network data to 3G using Chrome Dev tools etc.

The issue is a result of main.js being too slow to load and set the loading state.

On my fork at https://github.com/mobeigi/photography

I've fixed this and also made a handful of other improvements including:

  • Deffering script loads
  • Non blocking CSS / Font loads
  • Updating to latest multiverse
  • Using font-awesome v5
  • Making gulp minify every css + js file
  • GA4 tag support

I'd be happy to put up a PR for all of this, but my last pr was not reviewed so I don't know if its worth the time.

If it will be reviewed let me know and I can put up a PR @rampatra

@rampatra
Copy link
Owner

All the points you mentioned sounds interesting, would be great if you can raise a PR 🙏. And, your earlier PR is merged too.

@mobeigi
Copy link
Contributor Author

mobeigi commented Aug 18, 2024

Good to hear, I'll make a PR shortly with the improvements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants