-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump multiverse to latest, fix various bugs and improve performance #115
base: master
Are you sure you want to change the base?
Conversation
Okay, I will make some slight changes and approve. But it would be great if you can keep the functionality of the website same as before like the forms, etc. A few folks have said it earlier that it's helpful as one can easily plug that form to a form handler saas without much coding so in those cases it's quite handy. Yea, ads.txt was recommended by Google Ads but we do not need it now as there are no Google Ads shown. Thanks for removing it. |
Also, I do not understand why/how the spacing between the "Sponsor" section and the "Follow me on..." section is now gone. (from your screenshot attached) |
Sure thing we can add the contact form back in. Let me know if you are doing it as part of your changes or I can to. I'm not sure why the spacing may have broken for that section (maybe the new |
Hey Ram, I made the following changes:
Tested and working well on my end. |
Hey @rampatra, Let me know if you have a chance to review the above changes when you are not busy 👍 |
@rampatra Any chance this can be merged? Its basically good to go. Been running it live for 2 months now with no issues. |
Changes
5.0.0
07/03/2022
)v5.15.4
webrick
from Gemfile (seems unused?)ads.txt
(seems unused?)jquery.poptrox.modified.js
(based onv2.5.2-dev
).mjs
)_config.yml
and use full classnames likefa fa-camera-retro
for font-awesome v5 icons. This is needed because in v5+ the icons are in different groups based on style.@import
)is-preload
in default.html to prevent initial page load flicker (fixes Initial loading flicker on first visit #114 )Screenshot
Review notes
webbrick
in Gemfile is used for anythingads.txt
was needed for anythingjquery.poptrox.js
is the minified variant. I have contacted @ajlkn from (https://github.com/ajlkn/jquery.poptrox) to see if he will share unminified version ofv2.5.2-dev
Presentify
sponsor logo url is broken (because the Github signature probably expired). You can fix that in a different PR.CC: @rampatra