Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Update UI to allow choosing a ResourceSet on Backup creation #12997

Open
jbiers opened this issue Jan 6, 2025 · 2 comments
Open

[RFE] Update UI to allow choosing a ResourceSet on Backup creation #12997

jbiers opened this issue Jan 6, 2025 · 2 comments
Assignees
Labels
JIRA kind/enhancement QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone

Comments

@jbiers
Copy link
Member

jbiers commented Jan 6, 2025

SURE-9545

Describe the solution you'd like
When creating a Backup resource using the Backup&Restore Operator, a user goes to the following screen:
image

We want to add a new section to this screen, called ResourceSets. It will be meant for setting the value of the spec.resourceSetName. field in the Backup CR.

Ideally, this section will contain a dropdown menu with all ResourceSet resources available in the cluster, and will currently default to rancher-resource-set.

Along with the dropdown, a line of text with the content "Enabling encryption is highly recommended when using rancher-resource-set-full, otherwise sensitive information will be backed up as plain-text. Read more." should be added. Note that "read more" is a link to the relevant docs page and section.

Additional context
rancher/backup-restore-operator#607

@jbiers jbiers added this to the v2.11.0 milestone Jan 6, 2025
@richard-cox
Copy link
Member

@jbiers Will there be any RBAC issues with ResourceSet, how many ResourceSet's would you imagine customers have (10s, 1000s, 10,000s)?

Note for anyone working on this, ResourceSet is resources.cattle.io.resourceset visible once Rancher Backups is installed on upstream/local cluster. The screen in question is Rancher Backups --> Backup --> Create. The name of the section should just be Resource Set

@richard-cox richard-cox transferred this issue from rancher/rancher Jan 7, 2025
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Jan 7, 2025
@richard-cox richard-cox modified the milestones: v2.11.0, v2.12.0 Jan 7, 2025
@jbiers
Copy link
Member Author

jbiers commented Jan 17, 2025

@richard-cox I don't think any RBAC issues will be faced. As for number of resources, I'd expect users to have no more than a couple 10s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JIRA kind/enhancement QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

No branches or pull requests

3 participants