Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress Rules tab misbehaving with enter key #13147

Open
aalves08 opened this issue Jan 17, 2025 · 0 comments
Open

Ingress Rules tab misbehaving with enter key #13147

aalves08 opened this issue Jan 17, 2025 · 0 comments
Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this

Comments

@aalves08
Copy link
Member

Setup

  • Rancher version: 2.9x up to 2.11 (master)
  • Rancher UI Extensions: n/a
  • Browser type & version: any

Describe the bug

On the create screen for ingresses - rules tab - if the user focuses on the request host and presses the enter key, a row for rules path disappears. If you focus again on that same input and press enter it appears again

To Reproduce

On the create screen for ingresses - rules tab - if the user focuses on the request host and presses the enter key, a row for rules path disappears. If you focus again on that same input and press enter it appears again

Result
adds/removes a rules path row

Expected Result

should not have any implication with the rules path rows

Screenshots

Screen.Recording.2025-01-17.at.16.45.08.mov

Additional context

If you console.log on this method in RulePath https://github.com/rancher/dashboard/blob/master/shell/edit/networking.k8s.io.ingress/RulePath.vue#L102-L105 you'll see that the enter key press triggers this method on the @click.

Same for when it's adding a new row via the weird enterbehaviour, this method on @click triggers https://github.com/rancher/dashboard/blob/master/shell/edit/networking.k8s.io.ingress/Rule.vue#L167-L173

All evidence points to some weird propagation of events, since both those elements are button elements and those capture enter keypresses.

TBD how is this being exactly propagated and what is the correct fix. Smoking gun is that if you replace those button elements for span with the same @click handlers the bug disappears

@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

No branches or pull requests

1 participant