Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App still crashes on Rest = 0 #11

Open
waij opened this issue Nov 14, 2024 · 0 comments
Open

App still crashes on Rest = 0 #11

waij opened this issue Nov 14, 2024 · 0 comments

Comments

@waij
Copy link

waij commented Nov 14, 2024

You solved issue #7 by not allowing setting Rest = 0. This is problematic for several reasons.

  1. I consider repeated countdown without rest to be a valid use case.
  2. The rest period can still be set to zero, crashing the app.
  3. If you attempt to enter Rest = 0, the Rest field will remain empty. You can still start the timer. It crashes immediately.

Scenario for item 2:

  • start the interval timer
  • set Active = 5, Rest = 10
  • edit the value 10 by removing the 1, leaving the number 0 as the value
  • start the timer
  • timer runs as expected in cycles of 5 seconds
  • stop the timer
  • the rest field is now empty (this is unexpected behavior)

  • start the timer
  • the timer crashes

For completeness: the app also crashes with Active = 0 and Rest = 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant