You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't really understand the changes done here: #232
It doesn't look like something is wrong on my side. The tests are broken. test_pkg is skipped for dread and sr because it doesn't return any files for dread_data.all_files_ending_with(".pkg") (or the sr equivalent). (Didn't looked at any other tests)
is setting versions = -1 if there is no versions entry in the json but to versions = 0 if there is an empty array. As all .pkg have an empty array, they end up with versions = 0.
I don't really understand the changes done here: #232
It doesn't look like something is wrong on my side. The tests are broken.
test_pkg
is skipped for dread and sr because it doesn't return any files fordread_data.all_files_ending_with(".pkg")
(or the sr equivalent). (Didn't looked at any other tests)In the
sr_resource_names.json
some files have noversion
and some have aversion: []
What is the reason for that?https://github.com/randovania/mercury-engine-data-structures/blob/main/src/mercury_engine_data_structures/sr_resource_names.json
This part
mercury-engine-data-structures/src/mercury_engine_data_structures/samus_returns_data.py
Lines 33 to 38 in 786678f
versions = -1
if there is noversions
entry in the json but toversions = 0
if there is an empty array. As all.pkg
have an empty array, they end up withversions = 0
.mercury-engine-data-structures/src/mercury_engine_data_structures/samus_returns_data.py
Line 46 in 786678f
if v["versions"] & bitmask != 0
=>0 & -1 != 0
isfalse
for all pkgs (or in general for all files with an emptyversions
array in the.json
)The text was updated successfully, but these errors were encountered: