Add VSCode folder to gitignore #255
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
=======================================
Coverage 78.85% 78.85%
=======================================
Files 80 80
Lines 4323 4323
=======================================
Hits 3409 3409
Misses 914 914 ☔ View full report in Codecov by Sentry. |
.vscode/settings.json
Outdated
There was a problem hiding this comment.
All lines besides "python.testing.pytestEnabled": true, are the default values.
Any reason why they are added?
There was a problem hiding this comment.
So that it works out of the box.
There was a problem hiding this comment.
if the values are default they should work out of the box, no?
There was a problem hiding this comment.
I'm pretty sure the env file isn't default anyways. The rest is auto-generated by VSCode but without declaring the env file it won't work.
There was a problem hiding this comment.
The path for the env file is the default.
There was a problem hiding this comment.
I think it's fine as is. Just gitignore the vscode folder and people can add their own settings file
There was a problem hiding this comment.
I thought the intent was for people to have some default template already so that its easier for them writing said settings file?
There was a problem hiding this comment.
No, the intent is to ignore the vscode folder. I thought it would be convenient to include the files while I was at it, but that's not necessary since it's all default when selecting pytest. That's also extra files people with other IDEs don't need.
There was a problem hiding this comment.
Besides, if we really wanted that we could just add it later. It's more useful to get the gitignore merged now
There was a problem hiding this comment.
I agree. It's already helpful to have in this current state.
Adds a basic settings file, then gitignores the
.vscodefolder