Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Exceptions shown in stderr when running PARQUET_TESTS #17827

Open
davidwendt opened this issue Jan 27, 2025 · 3 comments
Open

[BUG] Exceptions shown in stderr when running PARQUET_TESTS #17827

davidwendt opened this issue Jan 27, 2025 · 3 comments
Labels
bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code.

Comments

@davidwendt
Copy link
Contributor

Running PARQUET_TESTS shows several errors and warnings to stderr. It is unclear if they are expected or not so if it is possible to suppress them when expected, it would make it easier to discern it them from actual errors.

[ RUN      ] ParquetChunkedWriterTest.MismatchedTypes
[2025-01-24 16:32:19.641] [CUDF] [error] Parquet writer encountered exception during processing. No data has been written to the sink.
[       OK ] ParquetChunkedWriterTest.MismatchedTypes (0 ms)

[ RUN      ] ParquetChunkedWriterTest.MismatchedStructure
[2025-01-24 16:32:19.643] [CUDF] [error] Parquet writer encountered exception during processing. No data has been written to the sink.
[       OK ] ParquetChunkedWriterTest.MismatchedStructure (0 ms)

[ RUN      ] ParquetChunkedWriterTest.MismatchedStructureList
[2025-01-24 16:32:19.643] [CUDF] [error] Parquet writer encountered exception during processing. No data has been written to the sink.
[       OK ] ParquetChunkedWriterTest.MismatchedStructureList (0 ms)

[ RUN      ] ParquetWriterTest.DecimalWrite
[2025-01-24 16:32:21.694] [CUDF] [error] Parquet writer encountered exception during processing. No data has been written to the sink.
[2025-01-24 16:32:21.694] [CUDF] [warning] Parquet writer: writing a decimal column with precision < 10 as int64
[       OK ] ParquetWriterTest.DecimalWrite (1 ms)

[ RUN      ] ParquetWriterTest.UserNullabilityInvalid
[2025-01-24 16:32:22.059] [CUDF] [error] Parquet writer encountered exception during processing. No data has been written to the sink.
[       OK ] ParquetWriterTest.UserNullabilityInvalid (0 ms)

[ RUN      ] ParquetWriterTest.UserRequestedDictFallback
[2025-01-24 16:32:22.071] [CUDF] [warning] DICTIONARY encoding was requested, but resource constraints prevent its use
[       OK ] ParquetWriterTest.UserRequestedDictFallback (4 ms)

[ RUN      ] ParquetWriterTest.UserRequestedEncodings
[2025-01-24 16:32:22.075] [CUDF] [warning] DELTA_LENGTH_BYTE_ARRAY encoding is only supported for BYTE_ARRAY columns; the requested encoding will be ignored
[2025-01-24 16:32:22.075] [CUDF] [warning] DELTA_BYTE_ARRAY encoding is only supported for BYTE_ARRAY and FIXED_LEN_BYTE_ARRAY columns; the requested encoding will be ignored
[2025-01-24 16:32:22.075] [CUDF] [warning] DELTA_BINARY_PACKED encoding is only supported for INT32 and INT64 columns; the requested encoding will be ignored
[       OK ] ParquetWriterTest.UserRequestedEncodings (2 ms)

[ RUN      ] ParquetWriterTest.Decimal128DeltaByteArray
[2025-01-24 16:32:22.076] [CUDF] [warning] Decimal types cannot yet be encoded as DELTA_BYTE_ARRAY; the requested encoding will be ignored
[       OK ] ParquetWriterTest.Decimal128DeltaByteArray (0 ms)
@davidwendt davidwendt added bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. labels Jan 27, 2025
@mhaseeb123
Copy link
Member

Looks like we have an EXPECT_THROW()in all tests throwing an error above. We can look into suppressing them

@davidwendt
Copy link
Contributor Author

I believe @vuule mentioned just suppressing the log output somehow.

@vuule
Copy link
Contributor

vuule commented Jan 30, 2025

The first idea that comes to mind is to RAII the logging away in the tests we know are meant to run into invalid/semi-valid cases.
We can discuss whether tests that don't expect warnings/errors should fail if there are any such messages in the log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

No branches or pull requests

3 participants