Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent use of PICO_RP2350B in boards/include/boards #2286

Open
d-c-d opened this issue Feb 17, 2025 · 1 comment
Open

inconsistent use of PICO_RP2350B in boards/include/boards #2286

d-c-d opened this issue Feb 17, 2025 · 1 comment
Milestone

Comments

@d-c-d
Copy link
Contributor

d-c-d commented Feb 17, 2025

It appears to be a typo that boards/include/boards/hellbender_0001.h is selecting the RP2350 VARIANT
by defining

#define PICO_RP2350B 1

The other board files ( even the likely associated src/boards/include/boards/hellbender_2350A_devboard.h ) seem to use

#define PICO_RP2350A 1

to indicate that "the current board has an RP2350 in an A (30 GPIO) package"
while the following is used to select the 48 pin RP2350B

PICO_RP2350A 0

Perhaps @CBJamo can comment

@lurch
Copy link
Contributor

lurch commented Feb 17, 2025

Oooh, well spotted! #2290 updates the script which checks board headers to look for #define PICO_RP2350B.

@kilograham kilograham added this to the 2.1.2 milestone Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants