Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Check Redis cleanup in Golang e2e tests #2764

Open
1 of 2 tasks
kevin85421 opened this issue Jan 17, 2025 · 5 comments · Fixed by #2773
Open
1 of 2 tasks

[Feature] Check Redis cleanup in Golang e2e tests #2764

kevin85421 opened this issue Jan 17, 2025 · 5 comments · Fixed by #2773
Assignees
Labels
1.4.0 enhancement New feature or request ray

Comments

@kevin85421
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

No response

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@kevin85421 kevin85421 added enhancement New feature or request triage labels Jan 17, 2025
@rueian
Copy link
Contributor

rueian commented Jan 17, 2025

Could I take this?

@kevin85421
Copy link
Member Author

Redis cleanup doesn't work with Redis 7.4, but it works with Redis 5.0.8.

Image

@rueian
Copy link
Contributor

rueian commented Jan 17, 2025

Redis cleanup doesn't work with Redis 7.4, but it works with Redis 5.0.8.

Well, looks like it actually cleaned up Redis successfully. See the message Finished deleting keys with external storage namespace.

The last malloc(): mismatching next->prev_size seems to be another bug in Ray.

@rueian
Copy link
Contributor

rueian commented Jan 18, 2025

Hi @kevin85421, the e2e helper for checking Redis cleanup has been added in #2773, and all tests pass. However, I didn’t see the malloc message on my side:

Image

I wonder if it is related to the underlying operator system.

@kevin85421
Copy link
Member Author

Reopening the issue because Ray still requires some fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.4.0 enhancement New feature or request ray
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants