Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makePayment() fails silently when given bad Body params #3

Open
raychz opened this issue Nov 13, 2018 · 0 comments
Open

makePayment() fails silently when given bad Body params #3

raychz opened this issue Nov 13, 2018 · 0 comments

Comments

@raychz
Copy link
Owner

raychz commented Nov 13, 2018

Like #2, we need to do better error handling, and return to the client a response that makes sense. When sending a POST to /payment with bad vals, I get a 201 with an empty response. Logging the response from Spreedly is a different story though:

{ errors: [ { key: 'errors.payment_method_or_payment_method_token_required',
       message: 'You must specify a valid \'payment_method\' or valid \'payment_method_token\' parameter.' } ] 
}
@raychz raychz changed the title makePayment() fails silently when given bad params makePayment() fails silently when given bad Body params Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants