Remove encodeURIComponent

[aubergene]

Currently produce splits on new line and then runs encodeURIComponent on each item, which I think could be removed. You stated in #63

The spec itself doesn't say anything about uri encoding, but without uri encoding messages would split into chunks on new lines.

but this is already happening

emit('message', the time is ${Date.now()}\nhere's a new line);

id: 1
event: message
data: the%20time%20is%201736267516899
data: here's%20a%20new%20line

I'm proposing the output should look like below, so newlines produce another data output, which I think meets the spec

id: 1
event: message
data: the time is 1736267516899
data: here's a new line

I'm looking to use this to replace an existing SSE endpoint where we're outputting JSON on a single line so the URI encoding breaks our existing consumers

Big thanks for this library it's great otherwise. Happy to write a PR but wanted to check thoughts first in a issue

[razshare]

Hello @aubergene , thanks for the issue.

I believe you're correct.
Reading this I just realized that both id and event are included with each emit call, obviously, which means there should be no ambiguity to which event a data payload is related to.

sveltekit-sse/src/lib/produce.js

Lines 36 to 45 in e5ade90

	controller.enqueue(encoder.encode(`id: ${id}\nevent: ${eventName}\n`))
	const chunks = data.split('\n')
	for (const chunk of chunks) {
	controller.enqueue(
	encoder.encode(`data: ${encodeURIComponent(chunk)}\n`),
	)
	}
	controller.enqueue(encoder.encode('\n'))
	id++
	return ok()

That was my main concern initially, but since JS is single threaded there shouldn't be any risk for a different data payload that belongs to a different event to be injected between those splits, unless we're dealing with workers. But that's a matter for another day to solve.

I'll run tests without the uri encoding/decoding and make sure it still behaves the same.

[razshare]

but this is already happening

Also yes, it's splitting the string then encoding the chunks, which makes no sense.

[razshare]

I'll run tests without the uri encoding/decoding and make sure it still behaves the same.

Everything looks fine without the uri encoding/decoding, I've just release version 0.13.12.
Try update to it and let me know if this fixes your issue.

[aubergene]

Thank you! That's great