-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Thunder SDK Caches Configurable #235
Comments
Right now we have a config field in the extension manifest for such requirements. A distributor can set the
Then one can do |
brendanobra
pushed a commit
to brendanobra/Ripple
that referenced
this issue
Feb 2, 2025
* fix: pinning loose deps (rdkcentral#242) * fix: pinning loose deps * fix: ripple oss rc * fix: adding Cargo.lock * fix: loose deps * fix: ripple_comcast_extns * fix: RPPL-1820: Ops Metrics Histograms (rdkcentral#235) * fix: RPPL-1820: ops metrics * cleanup * cleanup * fix: unit test compilation * fix: broken test compile * fix: unit test compilation * fix: removing feature * chore: clippy * fix: removing public key * rebase: ripple oss 1.3.0.rc * docs: janus * chore: latest extensions * merge: rollups * Update janus.md * Update janus.md * chore: Cargo.lock * chore: firebolt-devices * chore: Ripple-1.3.1 * chore: Ripple PR * chore: fixing dpab_core weirdness * Update janus.md * chore: updates * chore: Ripple main * chore: latest ripple_comcast_extns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
thunder_ripple_sdk
has caching implemented around all of the device_info calls that are made to Thunder. This will make testing or local development with the Mock Device extension very difficult as there is no way to clear the cache after the first call of any particular method is made.We need to add the ability to disable this cache in certain environments. This should be done by updating the extn manifest to have a property which enables or disables this cache.
I am not sure what the best way to express this is in the extn manifest file as this property would be generic to this specific extension. It also doesn't seem right to place the config in the device manifest. Maybe we need to have a settings field in the extn manifest where extensions can define their own options.
The text was updated successfully, but these errors were encountered: