Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token support removed #262

Closed
wants to merge 1 commit into from
Closed

Token support removed #262

wants to merge 1 commit into from

Conversation

joseinweb
Copy link
Contributor

@joseinweb joseinweb commented Oct 3, 2023 •
edited
Loading

What

Token support from generic devices

Why

Without a vendor, we can't support authorization

How

Remove the capability of the device.

Test

Any token for token should be denied

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

@joseinweb joseinweb linked an issue Oct 3, 2023 that may be closed by this pull request
Remove token support from generic builds #248
Open
@joseinweb joseinweb marked this pull request as ready for review October 3, 2023 16:55
@satlead satlead added needs-onboarding Changes which need to be onboarded for testing OSS-only Changes which impact only Opensource Ripple ready-for-qa labels Oct 3, 2023
@satlead
Copy link
Collaborator

satlead commented Oct 27, 2023

Can we merge this into #287

@satlead
Copy link
Collaborator

satlead commented Nov 4, 2023

Added as part of #287

@satlead satlead closed this Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-onboarding Changes which need to be onboarded for testing OSS-only Changes which impact only Opensource Ripple ready-for-qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove token support from generic builds
2 participants
@joseinweb @satlead