gh #44 Remove ODM specific apis - phase2 #45
Conversation
arjunbinu
force-pushed
the
feature/gh44_odm_api_removal_phase2
branch
from
5627ff1 to
62770fa
Compare
arjunbinu
force-pushed
the
feature/gh44_odm_api_removal_phase2
branch
from
62770fa to
084051b
Compare
arjunbinu
force-pushed
the
feature/gh44_odm_api_removal_phase2
branch
from
d83b2b8 to
940dd14
Compare
| COMPONENT_ENABLE, //!< State is Enable | ||
| COMPONENT_RESET, //!< State is Reset | ||
| COMPONENT_MAX //!< End of enum | ||
| }tvcomponent_state_t; |
There was a problem hiding this comment.
Are tvcomponent_state_t, fp_mfrColorTemp_t, and input_source_offset_t supposed to be removed? This information is not present in the email conversations.
There was a problem hiding this comment.
All types in these ODM headers are marked as deprecated and supposed to be removed. I couldn't listing each type in the email, I provided a general description since the changes were just removal of deprecated types. Only for DolbyVision APIs, I have provided an explanation as it demanded some level of explanation in the way it shall be used for multiple modes. Please excuse if there was a lack of clarity.
There was a problem hiding this comment.
Thank you for the clarification. Please let me know once your testing is complete.
| COMPONENT_ENABLE, //!< State is Enable | ||
| COMPONENT_RESET, //!< State is Reset | ||
| COMPONENT_MAX //!< End of enum | ||
| }tvcomponent_state_t; |
There was a problem hiding this comment.
Thank you for the clarification. Please let me know once your testing is complete.
Remove ODM specific APIs - phase2
Phase 1 PR was as follows:
https://github.com/rdkcentral/rdkv-halif-tvsettings/pull/43/files