Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: GetTVSupported APIs - The memory for modes must be allocated at caller end. #48

Open
slkanthi opened this issue Jan 7, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@slkanthi
Copy link

slkanthi commented Jan 7, 2025

Problem/Opportunity

The tvsettings.h interface documentation for the following APIs updated. Memory allocation responsibility is at the caller end.

GetTVSupportedDolbyVisionModes
GetTVSupportedVideoFormats
GetTVSupportedDimmingModes
GetTVSupportedPictureModes
GetTVSupportedVideoSources

Steps to reproduce

No response

Expected Behavior

The parameters must be passed according to the interface requirements.

Actual Behavior

GetTVSupportedPictureModes, GetTVSupportedVideoFormats, GetTVSupportedVideoSources, GetTVSupportedVideoSources, GetTVSupportedDolbyVisionModes does not properly use the array of pointers parameter in the HAL. Additionally, to match the current HAL code, the VTS code has been implemented, which is not the correct approach. The parameters must be passed according to the interface requirements. Changes are required in these APIs across the VTS L1/L2/L3 code.

Notes (Optional)

No response

@slkanthi slkanthi added the bug Something isn't working label Jan 7, 2025
slkanthi added a commit that referenced this issue Jan 7, 2025
@slkanthi slkanthi changed the title Bug: GetTVSupported related APIs - Allocate memory at caller end. Bug: GetTVSupported related APIs - The memory for modes must be allocated at caller end. Jan 7, 2025
@slkanthi slkanthi changed the title Bug: GetTVSupported related APIs - The memory for modes must be allocated at caller end. Bug: GetTVSupported APIs - The memory for modes must be allocated at caller end. Jan 7, 2025
@slkanthi slkanthi self-assigned this Jan 7, 2025
slkanthi added a commit that referenced this issue Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant