Replies: 2 comments 5 replies
-
One change I've already loosely considered is reworking the event emitter interface to no longer be string based and to provide actual functional hooks to each event. So instead of: scroller.on('scene:enter', d => {
d.element.classList.add('active');
}); It'd be: scroller.onSceneEnter(d => {
d.element.classList.add('active');
}); I think the string-based interface can be a bit error-prone (one typo and it's quietly failing), and it also loses out on the concrete type hints having a specific function call could provide. |
Beta Was this translation helpful? Give feedback.
-
Hey~! So I know it wasn't asked of me, but I set forth some pre-1.0 PRs to whittle down the size even further before breaking changes are introduced. I was playing with this version locally and I have to say, the event emitter / |
Beta Was this translation helpful? Give feedback.
-
Hello! I wanted to open up a space (and try out GitHub's new Discussions feature) to give users of Scroller a chance to speak up and give feedback on the state of the library and what it'd mean to go
1.0.0
.I can only speak for my work and the work of my colleagues at the LA Times, but despite this library having comfortably sat at
0.1.0
since it's initial release, I think it may be time to commit to a major version release. It's possible that nothing changes in that process, and it's simply a version bump! Or — there are some fixes and tweaks worth considering.Please let me know here if you have thoughts. If I decide something makes the cut and should be an actual issue, we'll migrate further discussion there about that specific feature.
Thank you!
Beta Was this translation helpful? Give feedback.
All reactions