Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DubStatus selection for Movies and TV Series #1546

Open
2 tasks done
JustRelaxable opened this issue Feb 7, 2025 · 0 comments
Open
2 tasks done

Add DubStatus selection for Movies and TV Series #1546

JustRelaxable opened this issue Feb 7, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@JustRelaxable
Copy link
Contributor

Describe your suggested feature

As far as i know there is no way to show DubStatus selection in the UI for TvSeriesLoadResponse and MovieLoadResponse. AnimeLoadResponse has this feature var episodes: MutableMap<DubStatus, List<Episode>> = mutableMapOf() though the Dub/Sub selection only appears if the type of the show is Series and not movies (ResultViewModel2.kt:2003): _selectedDubStatus.postValue(if (isMovie || currentDubStatus.size <= 1) null else)

It is not uncommon to see the same movie or tv series episode in two different video file for non-english languages, well at least for turkish.
They encode the subtitles in the video files.

Here is a demo PR for this feature (it probably needs a complete rework): #1545

Dub/Sub selection appears on the movie page with the PR:
Image

Other details

No response

Acknowledgements

  • My suggestion is NOT about adding a new provider
  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
@JustRelaxable JustRelaxable added the enhancement New feature or request label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant