kafka: Add batch size histogram #24865
Merged
+56
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename latency_probe to kafka probe such that we can add other shard wide kafka related measurements to it.
Let's extend the lower bound to 32 bytes? |
travisdowns
reviewed
Jan 21, 2025
Adds a batch size histogram. There is no per topic or partition info as that would cause a metric explosion due to the histogram. The histogram goes from 128 bytes to 1MiB.
StephanDollberg
force-pushed
the
stephan/batch-size-histogram
branch
from
9a65e3f to
09083d0
Compare
Done |
travisdowns
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a batch size histogram. There is no per topic or partition info as
that would cause a metric explosion due to the histogram.
The histogram goes from 128 bytes to 1MiB.
Ref CORE-8570
Backports Required
Release Notes