datalake: assign field ids to dlq record type #24966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvartolomei
force-pushed
the
nv/dlq-schema-bug
branch
from
306c6e3 to
44b4be7
Compare
nvartolomei
commented
Jan 28, 2025
src/v/datalake/record_multiplexer.cc
Outdated
| @@ -241,6 +241,10 @@ record_multiplexer::operator()(model::record_batch batch) { | |||
| ss::future<result<record_multiplexer::write_result, writer_error>> | |||
| record_multiplexer::end_of_stream() { | |||
| if (_error) { | |||
| // TODO: Call finish on all writeres to clean up resources. Redpanda | |||
There was a problem hiding this comment.
The crash is only in debug actually.
There was a problem hiding this comment.
Is this related to the change in this PR?
CI test resultstest results on build#61303
test results on build#61338
|
dotnwat
reviewed
Jan 28, 2025
andrwng
reviewed
Jan 28, 2025
There was a problem hiding this comment.
LGTM. Echoing Noah's point, for future readers (maybe our future selves) could you leave some context in the commit message: that this was just an oversight and we're just copying what we do for the main table, and what the behavior was before this (like did queries break before or something)
src/v/datalake/record_multiplexer.cc
Outdated
| @@ -241,6 +241,10 @@ record_multiplexer::operator()(model::record_batch batch) { | |||
| ss::future<result<record_multiplexer::write_result, writer_error>> | |||
| record_multiplexer::end_of_stream() { | |||
| if (_error) { | |||
| // TODO: Call finish on all writeres to clean up resources. Redpanda | |||
There was a problem hiding this comment.
Is this related to the change in this PR?
When testing iceberg integration with a proper rest catalog a bug was
found which caused translation to fail with the following log messages:
```
Error std::invalid_argument (Expected accessor for field id 5) while partitioning value: struct{struct{int(0), long(4), timestamp(1738071534491000), none, binary(size_bytes=0), }, binary(size_bytes=77), }
Error adding data to DLQ writer for record 4: Data Writer Error:1
```
The problem seems to be caused by the fact that there was a mismatch
between the schema we created locally and the partitioning spec returned
by the catalog.
The schema used for writing (in particular, field ids) should have been
taken from the rest catalog. The bug was caused by an omission due to my
misunderstanding on the translating machinery.
Added the missing call similar for how it is done for main table data
writing.
nvartolomei
force-pushed
the
nv/dlq-schema-bug
branch
from
44b4be7 to
a9f515e
Compare
andrwng
approved these changes
Jan 29, 2025
|
Thanks for adding the description @nvartolomei ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports Required
Release Notes