Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it using https://github.com/msgpack/msgpack-c internally? #2

Open
docteurklein opened this issue Mar 6, 2015 · 3 comments
Open

Comments

@docteurklein
Copy link

It seems it does.

Wouldn't a git submodule be more efficient to track changes?
Would an update of this lib be enough to be v5 compliant?

Thanks, and sorry to spam you :)

@reeze
Copy link
Owner

reeze commented Mar 6, 2015

I didn't try to update to latest version, I will try that next week too. And if you want you try it yourself.

I didn't use git submodule maybe I could do that too ;-)

@docteurklein
Copy link
Author

I don't know anything about C/C++ but if I get something working I'll tell you :)

@kklem0
Copy link

kklem0 commented Apr 8, 2015

It looks like a combined of https://github.com/reeze/msgpack-hhvm/tree/master/deps/msgpack and https://github.com/msgpack/msgpack-c/tree/master/include which makes it "harder" to make it as submodule, but yes this would make a lot of sense and it will be solution once and for all (assuming msgpack-c don't change their dir)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants