Is there a way to add a favicon?

[redtrillix]

I looked in the to-do and couldn't see anything about favicons so forgive me if I'm blind, but I was wondering if there is a way to have favicons, I've tried everything I can think of like having a 'favicon.ico' file in the root of both the program and the vfs and also tried the custom header with some html with no luck (from what I understand, it it used for the body so it makes sense it doesn't work).

Not sure if it is a limitation of node.js or something, but I believe it would be a great addition to the customisation we already have with hfs.

[rejetto]

the favicon is in the < head> part, while the header feature inserts stuff in the < body> part, because it's where the visible stuff is meant to be.

i guess it's technically possible to put some javascript there, to manipulate the < head>, but probably not ideal.
Not a limitation of node for sure, i just didn't work on it.
I just have to decide what's the best way, what's the best tool to give the user that will allow him to set the favicon.
A dedicated "favicon" option may be easier/clearer, even tho not powerful (you only do the favicon).

[redtrillix]

I would say, seeing as a favicon is a simple thing not much configuration is needed and we probably dont need anything too powerful, especially as a first implamentation.

[redtrillix]

i guess it's technically possible to put some javascript there, to manipulate the < head>, but probably not ideal.

For now I might see if theres a way to manipulate the header to get one working, just for the fun of it really.

[rejetto]

if you want to try, you add the < script> and use javascript to add something inside the < head>
but requires you to know javascript, or try adapting some code you find around.
LMK

[rejetto]

go chatgpt :D

[redtrillix]

yeah chatgpt has been quite helpful for code

[redtrillix]

You could probably do something like what you've done with html files and have an option to show an image or icon as a favicon.


Like this (just an example):

[rejetto]

well, i wasn't considering that serving /favicon.ico may actually be enough.
add it to your VFS and hide it.
try it :)

[rejetto]

mine is just latest chrome

[redtrillix]

thats weird, might be my browser but thats good to know, tried hard refreshing and even used incognito

I figured it out, it must be cloudflare cdn blocking because i can see it with lan ip

[rejetto]

if it's a cdn i guess it's just a cache (temporary) problem

[redtrillix]

nah i have bypass cache enabled

[redtrillix]

ive also had the favicon there for a long time

[rejetto]

ok, now we know adding the favicon to the vfs is (sort of) enough.
Still I have to decide what to do about it.
Letting user guess it (or google for it) is not ideal.

[rejetto]

while technically unnecessary, best user experience may still be to have a dedicated option in "configuration" page, i guess

[redtrillix]

yeah especially if they dont know where to put it, it might also allow it to be hidden from the root of the vfs with the other files/folders.

[rejetto]

well, of course once configured it would not be included in the list

[redtrillix]

it might just be cached, but it seems that the favicon will still load if its hidden.

Nope l lied, it was cached, if its marked as not downloadable, it doesnt show up.

but if you mark it as hidden from view but downloadable, it still works as a favicon:

[rejetto]

are you english mother tongue?
Would you let me know if you see english quirks in the GUI ?

[redtrillix]

is english my primary language?

[rejetto]

yeah

[redtrillix]

yes it is

i can do that for you
so far i haven't seen any quirks or issues but i will let you know if i do

[rejetto]

in next release

[HiCyprus]

Seems that only JPG files can be added as Favicon here in the Options Pages. But... JPG is not good enough for icon files. Can we choose png or ico files here? Anyway, we could put the file in the root folder(the way which I haven't tried)

[rejetto]

@HiCyprus what makes you think that only jpg can be added?
i'm using a png, for instance

[HiCyprus]

Thanks for the reply. I typed in the png file name directly and succeeded. But if I use the above UI, then only jpg files will be displayed to be chosen!

[rejetto]

right, i forgot to include png files in the list. Thanks for reporting. Will be fixed in next release