Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: extract deploying to staging in cd workflow #224

Closed
geekbrother opened this issue Sep 29, 2023 · 1 comment · Fixed by #226
Closed

chore: extract deploying to staging in cd workflow #224

geekbrother opened this issue Sep 29, 2023 · 1 comment · Fixed by #226
Assignees
Labels
accepted The issue has been accepted into the project area-github GitHub Actions

Comments

@geekbrother
Copy link
Contributor

geekbrother commented Sep 29, 2023

At the moment we can deploy only to the staging and prod environment together in our cd and auto_deploy workflows without the choice to deploy only to the staging environment.
Also, auto-deploy is triggered on merge and running deploying to the prod (without running release, example), so every merge the release is deployed to the prod without running release itself.

My proposal is:

  • auto_deploy on merging will deploy only to the staging,
  • cd can be triggered manually with the choice to deploy on the staging only or to both, as we already have in blockchain-api,
  • release triggering only manually and running cd with deploying to staging and prod.
@geekbrother geekbrother added the area-github GitHub Actions label Sep 29, 2023
@geekbrother geekbrother self-assigned this Sep 29, 2023
@arein arein added the accepted The issue has been accepted into the project label Sep 29, 2023
@geekbrother
Copy link
Contributor Author

The ability to send a branch to the staging is good for testing purposes, like testing #219 without deploying and touching prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted The issue has been accepted into the project area-github GitHub Actions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants