Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small app size increase in migration from WalletConnect to ReOwn #40

Open
simonmcl opened this issue Oct 24, 2024 · 0 comments
Open

Small app size increase in migration from WalletConnect to ReOwn #40

simonmcl opened this issue Oct 24, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@simonmcl
Copy link

Is your feature request related to a problem? Please describe.
It appears "CoinbaseWalletSDK" is now added to any project that uses ReOwn, regardless of whether you import or use AppKit. I only use WalletKit but its added to my project, resulting in a small increase. In the near future we are hoping to build an additional product that does require a very restrictive app size (can't go into details). Extra weight like this will determine which features we are able to add to this new product, which we had hoped wallet connect could be added too. Would it be possible to edit the package so that only AppKit users get this package?

@simonmcl simonmcl added the enhancement New feature or request label Oct 24, 2024
@llbartekll llbartekll self-assigned this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants