Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acknowledged property on returned session not updated #10

Open
acadams opened this issue Jan 21, 2025 · 1 comment
Open

Acknowledged property on returned session not updated #10

acadams opened this issue Jan 21, 2025 · 1 comment

Comments

@acadams
Copy link

acadams commented Jan 21, 2025

Describe the bug
When a session proposal is accepted, its acknoledged property is not updated on the returned object. Callers have to refresh the webpage to see if the peer acknowledged the connection.

SDK Version (if relevant)
@reown/walletkit 1.1.1
@walletconnect/core 2.17.1
@walletconnect/utils 2.17.1

To Reproduce
Steps to reproduce the behavior:

  1. Obtain a walletconnect uri and pair (I used Lido)
  2. Accept the proposed session
  3. View the returned session, and notice acknowledged is false, even though the dapp has acknowledged.
  4. Refresh the connecting app, and notice acknowledged is true.

Expected behavior
I would expect acknowledged's value on the returned session to represent the state of the connection.

Screenshots
I wasn't able to update an example video.

Desktop (please complete the following information):
Firefox 134.0.1 (aarch64)

Copy link

linear bot commented Jan 21, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant