Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

Image Build Fails on gapl language setup #177

Open
SteveCastle opened this issue Oct 14, 2020 · 2 comments
Open

Image Build Fails on gapl language setup #177

SteveCastle opened this issue Oct 14, 2020 · 2 comments

Comments

@SteveCastle
Copy link

Screen Shot 2020-10-14 at 4 08 55 PM

When building the image the build scripts call undup(line) in phase2.ejs while installing each language.

undup is a function in index.js that seems to comment out commands in the install array if they are already in the dc array in index.js. It seems like this means commands from previously installed languages would still be in that array including previous make and make install?

This causes the make and make install commands to be commented out, and the apl binary to fail to be created and copied, causing a crash.

I was going to make a PR but I realized I don't really understand the point of the dup check in the first place so I thought I'd just comment.

@SteveCastle
Copy link
Author

I actually just removed the undup call from the ejs template to fix it for myself.

@SteveCastle
Copy link
Author

Plus it seems like a PR has already been approved to remove the language. I think the issue I mentioned could still happen to other languages though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant