Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Back" button on certain resources opens the editor #3628

Open
8 tasks
PascalRepond opened this issue Mar 13, 2024 · 0 comments · May be fixed by rero/ng-core#614
Open
8 tasks

"Back" button on certain resources opens the editor #3628

PascalRepond opened this issue Mar 13, 2024 · 0 comments · May be fixed by rero/ng-core#614
Assignees
Labels
bug Breaks something but is not blocking client request Issue reported by production libraries

Comments

@PascalRepond
Copy link
Contributor

PascalRepond commented Mar 13, 2024

Bug description:

If I edit an item or holdings and save. It brings me to the resource detailed view: which is OK and should not change.

But then, clicking the "back" button in the item detailed view (or in the browser) brings me back to the editor.

This does not happen with documents, patrons, or ILL requests. The back button brings me back to the previous page (usually a list result) and ignores editors. To be coherent, the behavior should be the same across the app.

Expected behavior:

In all cases, especially in resources detailed views, the "back" button should ignore editors while bringing the user back to the previous page.

Fix this button to ignore routes to following editors:

  • item
  • holdings
  • local fields
  • entity (local)
  • order line
  • acquisition account
  • library
  • template

Steps to Reproduce:

  1. Edit any item
  2. Click on "save", this brings you to the detailed view
  3. Click on "Back"
  4. You are back in the item editor.
@PascalRepond PascalRepond added the bug Breaks something but is not blocking label Mar 13, 2024
@PascalRepond PascalRepond added the client request Issue reported by production libraries label Mar 13, 2024
@PascalRepond PascalRepond moved this from Inbox to Product Backlog in RERO ILS issues Mar 13, 2024
@Garfield-fr Garfield-fr moved this from Product Backlog to In Development in RERO ILS issues Apr 30, 2024
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue Apr 30, 2024
When a resource is added or modified, it is not always returned
to the correct page. The editor now uses the previous url to redirect.

* Closes rero/rero-ils#3628.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr linked a pull request Apr 30, 2024 that will close this issue
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue Apr 30, 2024
When a resource is added or modified, it is not always returned
to the correct page. The editor now uses the previous url to redirect.

* Closes rero/rero-ils#3628.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue Apr 30, 2024
When a resource is added or modified, it is not always returned
to the correct page. The editor now uses the previous url to redirect.

* Closes rero/rero-ils#3628.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr moved this from In Development to Ready to test in RERO ILS issues Apr 30, 2024
Garfield-fr added a commit to rero/ng-core that referenced this issue May 7, 2024
When a resource is added or modified, it is not always returned
to the correct page. The editor now uses the previous url to redirect.

* Closes rero/rero-ils#3628.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr moved this from Ready to test to In Development in RERO ILS issues May 8, 2024
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue May 8, 2024
When a resource is added or modified, it is not always returned
to the correct page. The editor now uses the previous url to redirect.

* Closes rero/rero-ils#3628.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to rero/ng-core that referenced this issue May 14, 2024
When a resource is added or modified, it is not always returned
to the correct page. The editor now uses the previous url to redirect.

* Closes rero/rero-ils#3628.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@PascalRepond PascalRepond moved this from In Development to Product Backlog in RERO ILS issues May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something but is not blocking client request Issue reported by production libraries
Projects
Status: Product Backlog
Development

Successfully merging a pull request may close this issue.

2 participants