Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in Forex Payment Entry (Buying) #3171

Open
1 task done
nitin-anantpranali opened this issue Mar 8, 2025 · 3 comments
Open
1 task done

Issue in Forex Payment Entry (Buying) #3171

nitin-anantpranali opened this issue Mar 8, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@nitin-anantpranali
Copy link

Information about bug

We have following Settings.
Company Currency : INR
Overseas Supplier : ABC
Supplier Currency : EUR
Supplier Group Currency : EUR

Purchase of Items in EUR with Conv. Rate = 91.00

Purchase Invoice is Booked successfully.

Now Passing Payment Entry from Purchase Invoice
Party type : Supplier
Supplier : ABC
Target Exchange Rate : 93
Payment References : Adjusted the above Purchase Invoice
Unallocated Amount (EUR) : 0
Difference Amount (INR) : 0

Saved but while Submitting giving Error as

Message
Error: Value missing for Journal Entry: Company GSTIN

So in GST Details >> Company Address >> Selected My Company Address
Then giving Error as

Message
Error: Value missing for Journal Entry: Company GSTIN

Console Error

request.js:473 Traceback (most recent call last):
File "apps/frappe/frappe/app.py", line 114, in application
response = frappe.api.handle(request)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "apps/frappe/frappe/api/init.py", line 49, in handle
data = endpoint(**arguments)
^^^^^^^^^^^^^^^^^^^^^
File "apps/frappe/frappe/api/v1.py", line 36, in handle_rpc_call
return frappe.handler.handle()
^^^^^^^^^^^^^^^^^^^^^^^
File "apps/frappe/frappe/handler.py", line 50, in handle
data = execute_cmd(cmd)
^^^^^^^^^^^^^^^^
File "apps/frappe/frappe/handler.py", line 86, in execute_cmd
return frappe.call(method, **frappe.form_dict)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "apps/frappe/frappe/init.py", line 1726, in call
return fn(*args, **newargs)
^^^^^^^^^^^^^^^^^^^^
File "apps/frappe/frappe/utils/typing_validations.py", line 31, in wrapper
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "apps/frappe/frappe/desk/form/save.py", line 37, in savedocs
doc.submit()
File "apps/frappe/frappe/utils/typing_validations.py", line 31, in wrapper
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "apps/frappe/frappe/model/document.py", line 1060, in submit
return self._submit()
^^^^^^^^^^^^^^
File "apps/frappe/frappe/model/document.py", line 1043, in _submit
return self.save()
^^^^^^^^^^^
File "apps/frappe/frappe/model/document.py", line 342, in save
return self._save(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "apps/frappe/frappe/model/document.py", line 395, in _save
self.run_post_save_methods()
File "apps/frappe/frappe/model/document.py", line 1143, in run_post_save_methods
self.run_method("on_submit")
File "apps/frappe/frappe/model/document.py", line 974, in run_method
out = Document.hook(fn)(self, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "apps/frappe/frappe/model/document.py", line 1334, in composer
return composed(self, method, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "apps/frappe/frappe/model/document.py", line 1316, in runner
add_to_return_value(self, fn(self, *args, **kwargs))
^^^^^^^^^^^^^^^^^^^^^^^^^
File "apps/frappe/frappe/model/document.py", line 971, in fn
return method_object(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "apps/erpnext/erpnext/accounts/doctype/payment_entry/payment_entry.py", line 109, in on_submit
self.make_gl_entries()
File "apps/erpnext/erpnext/accounts/doctype/payment_entry/payment_entry.py", line 1224, in make_gl_entries
self.make_exchange_gain_loss_journal()
File "apps/erpnext/erpnext/controllers/accounts_controller.py", line 1522, in make_exchange_gain_loss_journal
je = create_gain_loss_journal(
^^^^^^^^^^^^^^^^^^^^^^^^^
File "apps/erpnext/erpnext/accounts/utils.py", line 2188, in create_gain_loss_journal
journal_entry.save()
File "apps/frappe/frappe/model/document.py", line 342, in save
return self._save(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "apps/frappe/frappe/model/document.py", line 364, in _save
return self.insert()
^^^^^^^^^^^^^
File "apps/frappe/frappe/model/document.py", line 296, in insert
self._validate()
File "apps/frappe/frappe/model/document.py", line 586, in _validate
self._validate_mandatory()
File "apps/frappe/frappe/model/document.py", line 923, in _validate_mandatory
raise frappe.MandatoryError(
frappe.exceptions.MandatoryError: [Journal Entry, ACC-JV-2025-00008]: company_gstin

Blocked aria-hidden on an element because its descendant retained focus. The focus must not be hidden from assistive technology users. Avoid using aria-hidden on a focused element or its ancestor. Consider using the inert attribute instead, which will also prevent focus. For more details, see the aria-hidden section of the WAI-ARIA specification at https://w3c.github.io/aria/#aria-hidden.
Element with focus: button
Ancestor with aria-hidden: <div class=​"modal fade" style=​"overflow:​ auto;​ z-index:​ 2000;​ display:​ block;​" tabindex=​"-1" aria-hidden=​"true">​…​​

Version

Installed Apps
ERPNext: v15.47.4 (HEAD)
Frappe Framework: v15.51.1 (HEAD)
Frappe HR: v15.37.1 (HEAD)
India Compliance: v15.14.6 (HEAD)
Raven: v2.0.0 (HEAD)

Relevant log output / Stack trace / Full Error Message.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@nitin-anantpranali nitin-anantpranali added the bug Something isn't working label Mar 8, 2025
Copy link

Connected to Huly®: IC-3300

@nitin-anantpranali
Copy link
Author

Observation :
The issue is arising when the Conv Rate is different in Both transactions.

@nitin-anantpranali
Copy link
Author

nitin-anantpranali commented Mar 8, 2025

Observation :
The issue is while creating the Journal Entry as the error says "Error: Value missing for Journal Entry: Company GSTIN".
At the attached lines.

For Overseas parties there is no GSTIN.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant