Skip to content
This repository has been archived by the owner on Jul 31, 2018. It is now read-only.

Prelude Loader violates 10.1.1 and user-functions may be hoisted above prelude #9

Open
IgnoredAmbience opened this issue Mar 10, 2015 · 3 comments
Assignees
Milestone

Comments

@IgnoredAmbience
Copy link
Member

Concatenation of separate JS programs into one Program means that we do not use the correct strictness for them all if they differ.
We should read each Program in separately.

Additionally, prelude functions, such as those used by conrad for his global object setup may be shadowed by user-code functions that are hoisted above them.

List.concat (List.map (fun f ->

https://es5.github.io/#x10.1.1

@IgnoredAmbience IgnoredAmbience changed the title Prelude Loader violates 10.1.1 Prelude Loader violates 10.1.1 and user-functions may be hoisted above prelude Mar 10, 2015
conrad-watt pushed a commit that referenced this issue Mar 10, 2015
… the user program. #9 not completely fixed yet, need to incrementally execute prelude files instead of concatenating.
@IgnoredAmbience
Copy link
Member Author

I think this is causing the failure of ch10/10.4/10.4.3/10.4.3-1-17gs.js

@IgnoredAmbience
Copy link
Member Author

and tests/test262/ch10/10.4/10.4.3/10.4.3-1-19gs.js

@IgnoredAmbience IgnoredAmbience added this to the CAV Paper milestone May 1, 2015
@IgnoredAmbience
Copy link
Member Author

Can confirm the commit on this ticket hasn't fixed the listed test cases.

IgnoredAmbience pushed a commit that referenced this issue Aug 1, 2015
… the user program. #9 not completely fixed yet, need to incrementally execute prelude files instead of concatenating.
IgnoredAmbience added a commit that referenced this issue May 18, 2016
This will permit us to run the test262 prelude in a separate context
from the testcase itself.
This was a bug in the original JSRef, see issue #9:
#9
IgnoredAmbience added a commit to jscert/jsexplain that referenced this issue Oct 6, 2016
This will permit us to run the test262 prelude in a separate context
from the testcase itself.
This was a bug in the original JSRef, see issue #9:
resource-reasoning/jscert_dev#9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants