Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation requirements could be more specific (ROOT version) #333

Open
lobis opened this issue Nov 24, 2022 · 2 comments
Open

Installation requirements could be more specific (ROOT version) #333

lobis opened this issue Nov 24, 2022 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed

Comments

@lobis
Copy link
Member

lobis commented Nov 24, 2022

Some colleages that were installing REST-for-Physics for the first time understood from the documentation that REST is compatible with ROOT >6 but it failed to install on v6.22.02 even though it was compield with c++17 support.

We should define a specific minimum version of root that is supported and also add it to our CI, atleast compile REST on this.

@lobis lobis added documentation Improvements or additions to documentation help wanted Extra attention is needed labels Nov 24, 2022
@jgalan
Copy link
Member

jgalan commented Nov 24, 2022

In principle it should compile also with ROOT 6.22, why it doesn't?

We should try to encourage the use of a particular version, e.g. the one defined by the script ./installROOT.sh, as described here: https://rest-for-physics.github.io/installation.

Perhaps that documentation could be improved to emphasise and encourage the installation of a particular version, and particular compilation flags. Those found at the script installROOT.sh.

@jgalan
Copy link
Member

jgalan commented Nov 25, 2022

Shall we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants