Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CeleryPingHealthCheck is catching BaseException and really, *really*, **really** shouldn't 😄 #354

Open
violuke opened this issue Jan 28, 2023 · 0 comments

Comments

@violuke
Copy link
Contributor

violuke commented Jan 28, 2023

There was some discussion on this in #240 and I really strongly disagree with the idea of catching BaseException (or even Exception for that matter), and I'm not alone.

We've had to remove this check and re-implement our own, which is much the same as this package's check but doesn't catch the BaseException. There might be some other errors to catch, like #340 does for CacheBackend, but they really should be caught properly and not just caught via BaseException.

I must also say Thank You to everyone who maintains this package, it really is very helpful for us 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant