Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 stack Refresh #11

Open
d87 opened this issue Sep 3, 2019 · 7 comments
Open

5 stack Refresh #11

d87 opened this issue Sep 3, 2019 · 7 comments

Comments

@d87
Copy link
Member

d87 commented Sep 3, 2019

There's an ancient combat log bug, that if a stackable debuff reaches its maximum it will no longer get SPELL_AURA_REFRESHED or anything at all

Affected spells:

  • Sunder Armor
  • Deadly Poison
  • Wound Poison
  • Fire Vuln
  • Winter's Chill
  • Shadow Weaving
  • Shadow Vulnerability (Warlock Shadowbolt)
@d87 d87 changed the title Sunder Armor and probably Deadly Poison Sunder Armor 5 stack Refresh Sep 3, 2019
@d87
Copy link
Member Author

d87 commented Sep 3, 2019

Made a workaround for Sunder Armor. Nothing can be done for others, disabled them all

@d87
Copy link
Member Author

d87 commented Sep 20, 2019

Turned out Shaman's Healing Way is also affected and that's a big deal. Have to make a workaround now

@d87
Copy link
Member Author

d87 commented Oct 11, 2019

As reported in #24 Mind Blast and Scorch don't refresh if damage gets fully absorbed

@d87 d87 changed the title Sunder Armor 5 stack Refresh 5 stack Refresh Oct 11, 2019
@Olorun
Copy link

Olorun commented Nov 8, 2019

Workaround idea for Winter's Chill (and Fire Vuln) would be to check hits of Frost damage spells (and scorch), although first there would need to be some kind of working talent check for other players (e.g. s LibGroupInspecT port for classic).

@d87
Copy link
Member Author

d87 commented Nov 8, 2019

Fire Vuln is already working like that, i didn't bother with winter's chill tho, because it's just naturally always on as part of a frostbolt spam

@d87
Copy link
Member Author

d87 commented Nov 8, 2019

Ok, added Winter's Chill. Works the same way, visible only if player has the talent.
Inspecting others is way harder than on live, because inspect range in like 8 yards and i think you can't even see talents.

@Olorun
Copy link

Olorun commented Jul 7, 2020

I'll once again suggest that sharing talents through this (or another) library would help solve the problem partly. The library could run a Talent check at the start, store it, and then share it with other library users. The players who have the talent will get flagged in some way, and the debuff duration will only be refreshed when those players hit the enemy with their spells.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants