Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real-World example: What do you need? #8

Open
rherwig opened this issue Feb 5, 2018 · 13 comments
Open

Real-World example: What do you need? #8

rherwig opened this issue Feb 5, 2018 · 13 comments

Comments

@rherwig
Copy link
Owner

rherwig commented Feb 5, 2018

Hey everyone,

since we plan on creating a real-world example for a PWA using this React 16, it would be great to know, what features you desire in a real-world example. Please suggest features here.

The first ones I can think of are:

  • All features of the regular master (SSR, webpack, ESNext)
  • API and react-router along with some mock requests
  • PWA features like app manifest and service worker
  • Maybe a self signed certificate with HTTP2?
@crabbits
Copy link
Contributor

These all sound good. One of the top of my head would be adding somethhing like react-helmet for tags, page titles etc, useful for seo if you're using the stack for a landing page.

@crabbits
Copy link
Contributor

Also maybe some tests, I usually use a mix of mocha, chai and enzyme.

@rherwig
Copy link
Owner Author

rherwig commented Feb 22, 2018

Never saw helmet before. I'm gonna take a look.

As far as testing goes, I used jest and enzyme for most of my react apps. But anyways, testing examples sound great.

@rachmawatiafrida
Copy link

Any news for React Helmet implementation?

@rherwig
Copy link
Owner Author

rherwig commented Apr 22, 2018

No progress so far, as I was kinda busy the last few weeks. I will create a dedicated issue for that and implement in the upcoming days

@dwjohnston
Copy link

Not sure if this is way out of scope of what you're asking, but basically I'm wanting a fully featured out of the box PWA with:

  • Authentication
  • Protected routes
  • Dynamic social media sharing tags
  • Forms
  • Blur in images

@rherwig
Copy link
Owner Author

rherwig commented Nov 24, 2018

I am actually working on a "real" PWA example right now.

Forms, progressive images and routing is definitely part of it!
However, auth and social sharing might be difficult to provide for a "ready to use" template project, since they either involve database access and/or personal API tokens.

@dwjohnston
Copy link

What's your deployment/hosting philosophy? I'm currently playing around with Kubernetes and container based microservices - but I'm finding it's probably way too complicated compared to something like Heroku.

@rherwig
Copy link
Owner Author

rherwig commented Dec 5, 2018

I'm not really sure... on the one hand, docker seems really nice. But there are lots of things to consider - like handling container restarts, clustering, ... Service like firebase and/or heroku work for me, but I tend to self-host my apps, using docker for development and ansible for deploying (but without the container).

@subhendukundu
Copy link

I am kinda stuck with how to deploy the app I have built on top this. :(
I am trying with firebase hosting.
Any suggestion?

@dwjohnston
Copy link

I am kinda stuck with how to deploy the app I have built on top this. :(
I am trying with firebase hosting.
Any suggestion?

I build this as a docker image - and deploy the docker image somewhere. He is an example application that does this: https://github.com/dwjohnston/tinymassive-demo/tree/master

@rherwig
Copy link
Owner Author

rherwig commented Feb 1, 2019

Using a docker container is generally a good approach. However, I would suggest to use pm2 instead of the pure node executable.

@Markkos89
Copy link

What about the Install button? :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants