Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing check of attributes in facade_attrs #85

Open
MaGering opened this issue Nov 17, 2022 · 2 comments
Open

Missing check of attributes in facade_attrs #85

MaGering opened this issue Nov 17, 2022 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@MaGering
Copy link
Collaborator

There is no consequence if I add attributes of a component which do not appear in its class to the csv files in facade_attrs.

I would expect a test or error message which ensure that a valid attribute is passed.

@MaGering MaGering added the bug Something isn't working label Nov 17, 2022
@MaGering
Copy link
Collaborator Author

The problem addressed in this issue led to: #86

@jnnr
Copy link
Collaborator

jnnr commented Dec 13, 2022

We can address this as soon as facades are dataclasses (oemof/oemof-tabular#44), which will allow us to drop facade_attrs documented manually in csv files.

@MaGering MaGering added this to the v0.0.3 milestone Sep 19, 2023
@MaGering MaGering modified the milestones: v0.0.3, v0.0.4 Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants