Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.0 Safes are not supported #2

Open
dagogodboss opened this issue May 16, 2022 · 11 comments
Open

1.3.0 Safes are not supported #2

dagogodboss opened this issue May 16, 2022 · 11 comments

Comments

@dagogodboss
Copy link

Whenever I try to deploy smart contract on rinkeby it returns a 422 when trying to propose a transaction.

@rmeissner
Copy link
Owner

Could you please share your hardhat config or a link to your project?

@rmeissner
Copy link
Owner

I will answer here rmeissner/hardhat-safe-deployer-example#1

@rmeissner rmeissner reopened this May 17, 2022
@rmeissner rmeissner changed the title Getting 422 error 1.3.0 Safes are not supported May 17, 2022
@rmeissner
Copy link
Owner

Currently the implementation only supports Safes with version from 1.0.0 to before 1.3.0 (exclusive).

To support 1.3.0 Safes it is required to adjust the EIP-712 domain: https://github.com/rmeissner/hardhat-safe-deployer/blob/main/src/adapter.ts#L76

@dagogodboss
Copy link
Author

What adjustments should I make.

@dagogodboss
Copy link
Author

Currently the implementation only supports Safes with version from 1.0.0 to before 1.3.0 (exclusive).

To support 1.3.0 Safes it is required to adjust the EIP-712 domain: https://github.com/rmeissner/hardhat-safe-deployer/blob/main/src/adapter.ts#L76

What should alter in eip712

@rmeissner
Copy link
Owner

This is something that needs to be adjusted in the project. Not much you can do right now

@dagogodboss
Copy link
Author

I need this, it is very urgent, and it is a major blocker in our project.
When can I expect a fix.

@rmeissner
Copy link
Owner

As this is a side project there is no guarantee on this. You can try patching it yourself if you need it right now

@dagogodboss
Copy link
Author

Can you give a guide line on how I can patch it or what you think I can do to fix it

@0xWarren
Copy link

@dagogodboss It works for me. #3

@dagogodboss
Copy link
Author

Okay i will ur pr and try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants