-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Saarland #119
Comments
This is my first point of contact with this projects code. Upon inspecting the saarland_scraper test cases I found mostly tests of internal and potentially private methods. I didn't feel confident enough to touch the scrapers implementation without a high level test perspective of: - Giving real world derived server response to scraper - Checking for extracted entries and their properties This commit adds webmock to stub the scrapers network calls. That way the used fixtures can be more easily checked against the real world responses or updated with current data in case the website changes their format again. references robbi5#119
- Input data was updated - Test expectations were updated TODO: Update DetailScraper references robbi5#119
Hi @robbi5, I tried to take a quick stab at fixing the saarland scraper without touching to much of the existing code. I'm pretty confident about the overview_scraper part. But since this is my first contact with the code base I'm not sure how to proceed any further. Are pull requests your preferred method of contribution? Unfortunately I'm not able to test the scraper and the changes in more depth with my current knowledge of the code base. |
Hi @enricogenauck, |
This is my first point of contact with this projects code. Upon inspecting the saarland_scraper test cases I found mostly tests of internal and potentially private methods. I didn't feel confident enough to touch the scrapers implementation without a high level test perspective of: - Giving real world derived server response to scraper - Checking for extracted entries and their properties This commit adds webmock to stub the scrapers network calls. That way the used fixtures can be more easily checked against the real world responses or updated with current data in case the website changes their format again. references robbi5#119
- Input data was updated - Test expectations were updated TODO: Update DetailScraper references robbi5#119
Had failing tests because of daylight saving time references robbi5#119
They changed their website again, this time it even doesn't look like Sharepoint anymore.
Overview:
Detail:
The text was updated successfully, but these errors were encountered: